slack icon indicating copy to clipboard operation
slack copied to clipboard

Feature Request: add option to subscribe to Pull Request review requests for a specific team

Open jeherve opened this issue 2 years ago • 68 comments

Is your feature request related to a problem? Please describe.

The /github subscribe command is a great start to start integrating GitHub into our team's Slack channel. However, it does not include any easy way to get notifications whenever someone requests a review from our GitHub team on a Pull Request in a repository of our organization.

Describe the solution you'd like

Ideally, I would love to see a new option such as:

/github subscribe owner/repo review_requested [team_name]

Describe alternatives you've considered

I've considered relying on scheduled reminders for this, but they lack some things that I believe the Slack integration may be able to offer:

  • Be notified once only.
  • Be notified as soon as the review is requested.
  • Be notified only for review requests for the team (scheduled reminders gather a list of Pull Requests pending review from the team and from individual members on the team)

Additional context

Related issues:

  • #382
  • #1384
  • #390

jeherve avatar Jul 28 '22 08:07 jeherve

Big fan of this! I hope it comes to the GitHub slack integration soon!

drewtwitchell avatar Aug 02 '22 15:08 drewtwitchell

+1 I would love to have this option.

istisiki avatar Aug 30 '22 01:08 istisiki

I would also love to see this implemented or at least being able to filter by specific label

pkukulski avatar Sep 19 '22 17:09 pkukulski

+1

rachidrhafour avatar Oct 27 '22 10:10 rachidrhafour

+1

GalGoldnerVizAI avatar Nov 26 '22 17:11 GalGoldnerVizAI

+1

CodesOf-Partha avatar Dec 21 '22 04:12 CodesOf-Partha

+1

wlai-wavefin avatar Jan 09 '23 17:01 wlai-wavefin

+1

fdmarc avatar Jan 11 '23 15:01 fdmarc

Looking forward to this also +1.

Kirk-Patrick avatar Jan 13 '23 21:01 Kirk-Patrick

+1

SauravPahadia avatar Jan 18 '23 16:01 SauravPahadia

+1

francescopepe avatar Jan 27 '23 11:01 francescopepe

+1

AndreiaMatiasSilva avatar Jan 27 '23 11:01 AndreiaMatiasSilva

same here, cant wait for this future

jjkazm avatar Jan 31 '23 14:01 jjkazm

Great feature, waiting for it super badly :)

aleksnamaniuk avatar Feb 03 '23 13:02 aleksnamaniuk

+1 would love to have this option!

amanda-allison avatar Feb 14 '23 15:02 amanda-allison

this would save lots of time

nwbt avatar Feb 15 '23 21:02 nwbt

would love to have this, It's would also nice to have notification when our PR were commented.

riyo-tiket avatar Feb 23 '23 02:02 riyo-tiket

+1

georgi-denchew avatar Feb 23 '23 08:02 georgi-denchew

+1 for reeaaaaal

srequiem avatar Mar 09 '23 12:03 srequiem

this works for me: https://rasim.pro/blog/personal-slack-github-notifications-for-pull-requests-reviewers-how-to-set-up/

jbart12 avatar Mar 09 '23 16:03 jbart12

+1 looking for this exact feature

emma-nayya avatar May 11 '23 16:05 emma-nayya

this works for me: rasim.pro/blog/personal-slack-github-notifications-for-pull-requests-reviewers-how-to-set-up

This post suggests using a GitHub feature named "scheduled reminders" for this. I do not think this is an appropriate solution for teams, as I mentioned in my original post.

jeherve avatar May 11 '23 18:05 jeherve

👍

jeffreyrubi avatar Jun 05 '23 15:06 jeffreyrubi

this works for me: rasim.pro/blog/personal-slack-github-notifications-for-pull-requests-reviewers-how-to-set-up

This post suggests using a GitHub feature named "scheduled reminders" for this. I do not think this is an appropriate solution for teams, as I mentioned in my original post.

Agree! Scheduled reminder does not work very well since it gives you a list of all open review requests. It's hard to distribute the review among team members.

vkyt avatar Jun 16 '23 13:06 vkyt

+1

echavemann avatar Jul 10 '23 20:07 echavemann

+1

timmkd avatar Jul 24 '23 00:07 timmkd

+1

kenngkz avatar Aug 07 '23 15:08 kenngkz

+1

willBampton avatar Aug 15 '23 09:08 willBampton

+1

lribeirocs avatar Aug 15 '23 19:08 lribeirocs

+1

thomas-pearson-mattr avatar Sep 01 '23 02:09 thomas-pearson-mattr