slack
slack copied to clipboard
Do not use green checkmark when checks fail.
When you have checks configure for your PR, Slack Github integration prints a message saying something like:
:white_check_mark: No checks have passed 0/4 successful checks
I think this is a bit confusing to look at a glance. As in, it's easy to think your build was good.
Describe the solution you'd like
If all checks pass, message should start with green check mark. If any checks fail, it should have for example 🔴 or 🟥 or ❌...
Describe alternatives you've considered
Maybe failing checks should get yellow X instead?
Additional context
In short, it is too easy to confuse this:
and this: