slack
slack copied to clipboard
integrations
"Remind authors after reviews" stopped working after updating to new version
Describe the bug
Having "Remind authors after reviews" enabled in Scheduled reminders doesn't result in the corresponding "Waiting for author" section being included in the notification.
Previously, with the legacy app, it was working fine. But with the new app it stopped working. Here is a screenshot of the messages from both legacy and new app for the same time: the "Pending review" list is identical in both, but the "Waiting for author" is gone in the latter:
The "Remind authors after reviews" setting is enabled:
No rush but we do think this will come back with new integration eventually or is this a limitation of the way the new one works? trying to figure out if we need to adjust our flow.
@bradical and @denho Sorry for the delayed response. We have made a note of this issue and are working on the fix. This should be available again by the end of this week.
@bradical We fixed one issue where the author's name was coming as blank.
My bad, I was referring to this issue in my previous comment.
Looks like you are not getting the remind authors at all. That is a missing feature in the new app. We are working to get this out in the next couple of weeks. I will update you.
Hi, has the missing feature been rolled out ? I haven't see "Remind authors after reviews" section in the reminder. Any new setting to enable it ?
Also does not work for us. This is pretty bleak considering Github acquired Pull Panda which did exactly this feature very well, then shut it down, and now their alternative is just not working at all with zero attention or intent to fix. Anyone know any good alternatives?
👋 The issue is still in our backlog. We lost track of this as we were busy with other tasks which were on priority. @ashokirla can we bump the priority on this one as a lot of users are requesting this..
Hey @ashokirla sorry but any further word on this? Just having a general "action is ready to be taken" notification every morning for both our reviewers and authors is pretty critical for us.
or do you have any suggested workarounds here?
@ashokirla This is also something our teams also depend on for our workflow. Just knowing roughly when this will be done can guide us in either changing our workflow or hold out the wait.
What can we do to signal the priority on this?
It's frustrating to loose track of approved PRs, and end up personally nagging authors (or be nagged) to merge them.
Hi! Any updates on this? Reminder is not notifying the PR author after the review has been fulfilled.
I believe that the notification sent in Slack is not including the mention to the author because once the review is fulfilled the PR is not satisfying the following check:
I also have the same issue still.
My current workaround is printing all PRs so that the notification includes the Author as the waiting action from..
it's not perfect but better than nothing
This problem still seems to exist.
The most frustrating part is that the option is there to enable when configuring the reminder, but it doesn't do anything. So until I found this, I assumed I had done something wrong and spent some time messing around with it, trying to get it working.
I had the same idea as Juanma, but de-selecting Require review requests removes the Remind authors after reviews option. This implies that the reminder feature understands they are related, and would handle this situation properly.
Even if we disable Require review requests and set Required labels to filter down the list of PRs instead, I've also had problems with the Ignore approved pull requests option not doing anything (seems like that is being discussed in #1453). So we would then have to go into a PR and remove the label if we want it to stop notifying Slack once it's reviewed.
