slack icon indicating copy to clipboard operation
slack copied to clipboard

New Github app doesn't allow unsubscribing to PR 'statuses'

Open sandersiim opened this issue 3 years ago • 12 comments

The old GitHub app allowed to unsubscribe from PR statuses related to checks under the PR. After upgrading to new app, the statuses information is now spammed with every opened PR notification and there doesn't seem to be any way to turn it off. Furthermore, the statuses don't even sync as checks are ultimately passed, making it completely useless spam.

How to turn PR statuses notifications off in the new app? Or alternatively, how can I revert back to the old app?

sandersiim avatar Apr 19 '21 09:04 sandersiim

Hello @sandersiim , with the new GitHub app for slack, you cannot unsubscribe statuses exclusively as in the old app. We will take this as a feedback and look into further improvement of the user experience.

apurva1112 avatar Apr 19 '21 10:04 apurva1112

But in the current state of things, what's the point of having PR statuses notified at all? Since the statuses are not updated accordingly, when corresponding Github Actions finish, it's just unnecessary spam in Slack. And better yet would be if it was possible to turn statuses off completely.

sandersiim avatar Apr 19 '21 11:04 sandersiim

Just fix it, don't "look into it." This is interfering with productive technical conversations image

vinniefalco avatar Apr 19 '21 15:04 vinniefalco

☝️ strongly agree.

sandersiim avatar Apr 19 '21 15:04 sandersiim

This has made our github updates channel completely unreadable, really looking forward to a quick fix!

ivokund avatar Apr 19 '21 15:04 ivokund

Is this integration open source? Is there the possibility of submitting a pull request that adds an option to hide the status messages?

vinniefalco avatar Apr 19 '21 16:04 vinniefalco

Apologies for the inconvenience. As we are continuing to work on adding more notification types, the current way of providing strings for each feature type to filter doesn't really scale. We intend to enable more granularity and customizability for the notifications you receive. To achieve that, we need to make this change so that we can standardize on the high level features (issues, prs, commits, releases, actions etc.) and then provide an advanced experience to further customize notifications for each of the features.

Please bear with us. This is the next priority functionality we will be working on and we sure you would appreciate this feature customizability once it is available.

Please let me know if you would like to know more about our plan or provide your valuable inputs. I am happy to discuss over a call.

ashokirla avatar Apr 19 '21 19:04 ashokirla

It would be nice if those CI status messages were collapsible (like images), and collapsed by default. This wouldn't require any work on the filtering interface (since it wouldn't have any options).

vinniefalco avatar Apr 19 '21 20:04 vinniefalco

Kindly prioritize it, we would like to filter the PR notifications based on the status

It would be nice if those CI status messages were collapsible (like images), and collapsed by default. This wouldn't require any work on the filtering interface (since it wouldn't have any options). @vinniefalco I think we can look into that to reduce the impact for now. We will get back to you with our plan here.

ashokirla avatar Apr 26 '21 16:04 ashokirla

We have evaluated this feedback. Today, the slack platform doesn't support ability to control when and where to collapse the messages. We have raised a feature request with the slack platform and we will implement this request once it is available.

ashokirla avatar Jun 07 '21 14:06 ashokirla

PLEASE help us... we put a man on the moon, can't we somehow inhibit all that output?

image

vinniefalco avatar Apr 13 '22 12:04 vinniefalco

@ashokirla Will this be coming with the Action Notification that was going to arrive in October? It sounds a bit like it. We also need this, since we just started going from 1 cypress run to 15.

odinho avatar Nov 24 '22 12:11 odinho

@odinho Yes, as part of Actions notifications, we are ensuring this problem is handled. We will show only the summary in the main card to reduce the clutter and the details of the jobs will be part of the thread. Here is a mock. Thread (1 failed, 1 approval)

This feature will be shipped on Dec-6.

However, the problem with PR card with checks still needs to be handled. We are waiting for a fix from Slack team as we don't control the UI.

ashokirla avatar Nov 24 '22 16:11 ashokirla

However, the problem with PR card with checks still needs to be handled. We are waiting for a fix from Slack team as we don't control the UI.

Well. For our case, just not having them at all on the PR card, or only having a combined one would be very good.

We don't need any extra UI for this. Even what you are doing here showing "extras" in a reply-thread seems to be a usable way to me. So I don't understand why any extra features are needed from Slack.

That just sounds like a recipe for having to wait forever. :)

odinho avatar Nov 24 '22 20:11 odinho

Still a problem unfortunately. image

vinniefalco avatar Nov 25 '22 18:11 vinniefalco

@ashokirla Is there any news? It's been 3 months since dec 6th, which supposed to be the release date.

gfpoliva avatar Mar 06 '23 21:03 gfpoliva

The sad state of it image

vinniefalco avatar Mar 06 '23 21:03 vinniefalco