No notifications for Comment reviews

[baelter]

No notifications are sent when a user makes a "Comment Review". I.e Add a comment to a PR with "Start Review" and them submit the review as "Comment".

[nickpoulos]

+1 this

And now Pull Reminder is being deprecated Jan 2021 🤦

[Kwutzke]

+1

[fecaps]

+1

[ashokirla]

@baelter @nickpoulos @Kwutzke You need to subscribe to reviews feature to get comments happened through reviews.

[dragos-scio]

+1

There should be a checkmark get alerts for ALL types of comments.

Pull Reminder was doing this perfectly.

This is such a big issue, that the slack app is almost useless, if I still need to check all my gmail notifications to make sure I don't miss anything, why have these notifications at all.

[TanguyP]

This issue is still occurring. Technically, it's not a bug, because in the configuration you can enable alerts for "Your PR is approved or has changes requested" and "Someone comments on your PR", but there's no alert for "Your PR is reviewed".

So if someone finalises their review with "Comment" (not "Approve" or "Request changes") and they don't fill in anything in the "Leave a comment" field (overall comment for the review), that's a scenario which doesn't match any existing alert, so no notification is sent.

Even though this is not an actual bug, I can't understand the rationale behind this design choice: why would you want to ignore Comment reviews? If some people do, then at the very least a separate checkbox for that should be provided.