slack icon indicating copy to clipboard operation
slack copied to clipboard

Subscribe with reviewer = [username|groupname]

Open kevinpeno opened this issue 3 years ago • 7 comments

We currently have to manually assign labels to trigger notifications to the correct slack channel based on code owners (groups in our case) automatically assigned to a PR. The trouble with this is it takes institutional knowledge to know which group will likely get flagged and, as such, people regularly label an incomplete list of owners or an incorrect set of owners.

It'd be nice to subscribe as follows to remove the need for the label. I imagine the filter working similar to labels.

/github subscribe owner/repository pulls +reviewer:@userOrGroupName

kevinpeno avatar Dec 02 '20 20:12 kevinpeno

Without this feature using notifications on any mono-repo setup is really painful.

terozio avatar Feb 18 '21 10:02 terozio

This is literally the only feature I was looking for. Notification about Pull Requests without filtering by username is noisy.

ddonahoevibrenthealth avatar Apr 28 '21 18:04 ddonahoevibrenthealth

I'd really love to see this implemented. Without this feature, I've just muted the app. Edit: I did find that you can get a similar experience in the github scheduled reminders section Screen Shot 2021-09-09 at 4 26 16 PM

spyderman4g63 avatar Sep 09 '21 14:09 spyderman4g63

@amitkumariiit is this something you're looking for help on? If so, can you point me to some reasonable documentation on how you're implementing (and where since it's not public) and any contribution guidelines you have?

kevinpeno avatar Jan 19 '22 01:01 kevinpeno

Is there any possibility of increasing the priority of this feature? :)

tooming avatar Jul 11 '23 12:07 tooming

Triggering notification via team reviewer on PRs is just non-negotiable, how has this not been prioritized since 2020?

Eeebru avatar Feb 27 '24 19:02 Eeebru

This is essential!

Nokinori avatar Apr 02 '24 14:04 Nokinori