microsoft-teams icon indicating copy to clipboard operation
microsoft-teams copied to clipboard

Add approval status to PR cards

Open matt-carr opened this issue 3 years ago • 2 comments

Describe the solution you'd like It would be really handy if the PR cards had a section for showing approvals, similar to checks.

e.g.

Reviewers: @joe-schmoe, @matt-carr ✔️, @someone-else ❌, @a-third-person 💬

Describe alternatives you've considered Alternatively, simply a status that shows whether or not a PR is ready to merge

e.g.

Reviewers: @joe-schmoe, @matt-carr, @someone-else, @a-third-person Review Status: Changes Requested ❌ Review Status: Approved ✔️ Review Status: Open

matt-carr avatar Apr 05 '21 17:04 matt-carr

Thanks for the feedback.

We already post Review status as a notification as part of the thread. Can you explain why you would need a separate status in the card.

ashokirla avatar Aug 26 '21 22:08 ashokirla

If there's further discussion after a review, the reviews may be buried in the comments thread - it would be ideal to have all the critical PR information available at a glance in the main card

matt-carr avatar Dec 03 '21 14:12 matt-carr

@ashokirla @matt-carr I agree. Just recently posted a reply to this thread with a similar request: https://github.com/integrations/microsoft-teams/issues/45#issuecomment-1286146027

bradcutshall avatar Oct 20 '22 21:10 bradcutshall