sonar-delphi icon indicating copy to clipboard operation
sonar-delphi copied to clipboard

False negatives for redundant jump rule

Open zaneduffield opened this issue 8 months ago • 0 comments

Prerequisites

  • [x] This improvement has not already been suggested.
  • [x] This improvement should not be implemented as a separate rule.

Rule to improve

RedundantJump

Improvement description

In the following example there are 2 redundant jumps that are not flagged by the current implementation of the rule

function Condition: Boolean;
begin
  Result := True;
end;

procedure Con;
begin
  for var I := 0 to 1 do begin
    if Condition then begin
      Continue; // not flagged
    end;
    Continue; // flagged
  end;
end;

procedure Brk;
begin
  for var I := 0 to 1 do begin
    if Condition then begin
      Break; // not flagged
    end;
    Break;
  end;
end;

Rationale

The rule should detect as many redundant jumps as possible, and this is another simple case to include.

zaneduffield avatar Mar 07 '25 02:03 zaneduffield