intake-xarray icon indicating copy to clipboard operation
intake-xarray copied to clipboard

Could netcdf4 be pulled out to isolate GPL code?

Open danielballan opened this issue 6 years ago • 5 comments

I think netcdf4 is inflected with GPL code. I'm wondering if it could be made an optional dependency of intake-xarray, or moved into a separate intake-netcdf4 package.

Although conda-forge reports that netcdf4 has an MIT liencse, netcdf4 has a hard dependency on cftime which has a GPL license.

h/t @dylanmcreynolds who noticed this problem.

danielballan avatar Jun 12 '19 19:06 danielballan

To be clear, I would be happy to do the work to make this happen if the maintainers of this package support the change.

danielballan avatar Jun 12 '19 19:06 danielballan

It would be ok by me to have this only as an optional dependency, but, of course, the docs had better be clear (and good error message on import failure).

martindurant avatar Jun 12 '19 21:06 martindurant

Yeah I am consistently surprised by the dependency on netcdf4. xarray doesn't depend on netcdf4, so we can probably look there for good error messaging.

jsignell avatar Sep 24 '19 19:09 jsignell

It's my understanding that the license inccompatibility issue in netcdf4-ptyhon/cftime got fixed a few days ago: https://github.com/Unidata/netcdf4-python/issues/1073.

andersy005 avatar Feb 14 '21 04:02 andersy005

Seems like the conscensus here is that it would be fine to remove the xarray dep, but I'm not sure whether there is any motivation for doing that if the license issue is resolved.

jsignell avatar Feb 15 '21 15:02 jsignell