mistral-actions icon indicating copy to clipboard operation
mistral-actions copied to clipboard

"mistral-actions discover" command gives ImportError

Open dineshbhor opened this issue 7 years ago • 0 comments

"mistral-actions discover" command gives ImportError for NotFoundException exception.

Steps:

1] Install int32bit/mistral-actions as suggested in README.rst 2] Try to execute "mistral-actions discover"

Got below error:

Traceback (most recent call last):
  File "/usr/local/bin/mistral-actions", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/mistral_actions/shell.py", line 214, in main
    MistralActionShell().main(argv)
  File "/usr/local/lib/python2.7/dist-packages/mistral_actions/shell.py", line 146, in main
    do_help=do_help, argv=argv)
  File "/usr/local/lib/python2.7/dist-packages/mistral_actions/shell.py", line 87, in get_subcommand_parser
    "mistral_actions.client.shell")
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 73, in import_module
    __import__(import_str)
  File "/usr/local/lib/python2.7/dist-packages/mistral_actions/client/shell.py", line 3, in <module>
    from mistral_actions.client import actions as actions_cli
  File "/usr/local/lib/python2.7/dist-packages/mistral_actions/client/actions.py", line 8, in <module>
    from mistral.exceptions import NotFoundException
ImportError: cannot import name NotFoundException

Recenlty a patch got merged in Mistral [1] which has changed "NotFoundException" to very specific "DBEntryNotFoundException" which was again changed to "DBEntityNotFoundError" [2].

Instead of NotFoundException we should import and use DBEntityNotFoundError.

[1] https://github.com/openstack/mistral/commit/96e6d7e40329edfb9fb855d30b324a76221eba32 [2] https://github.com/openstack/mistral/commit/e2c89f777d378e91c904a7e2bfc7e126bc80dde2

dineshbhor avatar Jul 21 '17 08:07 dineshbhor