squert icon indicating copy to clipboard operation
squert copied to clipboard

Fix for wrong signatures display

Open pmos69 opened this issue 11 years ago • 2 comments

For signatures like "sensitive_data: sensitive data - eMail addresses" (sid:5 gid:138) squert was displaying the wrong description.

pmos69 avatar Oct 16 '13 10:10 pmos69

As I was looking at your patch I was thinking 'that won't even fire' but it turns out the the check that is done earlier in that function is wrong, my intent was to stay out of that for loop completely if the GID was > 100 but with the <= it will run at least once :/

I want to re-check why I didn't want to process these GIDs before merging.

int13h avatar Oct 16 '13 19:10 int13h

:) looking at the code I thought the same thing, (that your intention was never to enter the loop). Then I thought I might be missing something because that way these types of sigs would never display correctly. Since I didn't want to end up looking like a jackass, I went for a quick&dirty fix again. :/

pmos69 avatar Oct 17 '13 00:10 pmos69