argocd-commenter icon indicating copy to clipboard operation
argocd-commenter copied to clipboard

Published 20 hours ago • verified publisher icon int128

Add full support for Argo CD external urls

Open Hronom opened this issue 1 year ago • 3 comments

Enables full support for External URL's in Argo CD. Otherwise it will throw error during updating deployment status.

I'm not go developer(but java), please check if it ok from go perspective. I'm providing my verbal approve to edit this PR by maintainers in order to merge it as fast as possible. Thanks!

Hronom avatar Mar 31 '24 01:03 Hronom

cc @int128

Hronom avatar Mar 31 '24 01:03 Hronom

📝 https://argo-cd.readthedocs.io/en/stable/user-guide/external-url/ https://github.com/argoproj/argo-cd/blob/f0b03071fc00fd81433d2c16861c193992d5a093/common/common.go#L178-L186

int128 avatar Apr 02 '24 01:04 int128

Keep in mind that official docs not reflect real useful functionality that they support in source https://github.com/argoproj/argo-cd/blob/f0b03071fc00fd81433d2c16861c193992d5a093/common/common.go#L186 I added comment in proposed changes about it

Hronom avatar Apr 03 '24 22:04 Hronom