manifest-guard icon indicating copy to clipboard operation
manifest-guard copied to clipboard

Fix description

Open MasterOfTouch opened this issue 2 years ago • 5 comments

image Also would be nice to mention that manifestGuard {} must be set in build.gradle of app module or show the usage of script in sample.

MasterOfTouch avatar Jan 13 '23 09:01 MasterOfTouch

Hello! Thank your request. README file was fixed.

Also would be nice to mention that manifestGuard {} must be set in build.gradle of app module

That is said in the first sentence in Setup section: "Also would be nice to mention that manifestGuard {} must be set in build.gradle of app module". Do you think this sentence should be rephrased?

show the usage of script in sample.

Yes, that's a good point. Currently, the sample relies only on the default config but meantime I didn't sort out how to show all possible configs in one sample.

int02h avatar Jan 17 '23 11:01 int02h

may be its only my lack of expierence of working with gradle plugins. but i had to spent some time to realize of where to insert manifestGuard {}

MasterOfTouch avatar Jan 23 '23 10:01 MasterOfTouch

also

maven {
           url "https://plugins.gradle.org/m2/"
       }

confusing since it's literally gradlePluginPortal() https://github.com/gradle/gradle/pull/613

MasterOfTouch avatar Jan 23 '23 12:01 MasterOfTouch

Yes, I usually copy code samples from official page.

int02h avatar Jan 31 '23 12:01 int02h

Almost always blocks for configuring plugins are placed just on the top level of build.gradle

int02h avatar Jan 31 '23 12:01 int02h