canvas-android icon indicating copy to clipboard operation
canvas-android copied to clipboard
verified publisher icon instructure

Remove Multidex usages

Open MGaetan89 opened this issue 1 year ago • 1 comments

Since the min SDK is at least 21, it is no longer necessary to use the Multidex library.

See the following for more info: https://developer.android.com/build/multidex#mdex-on-l

MGaetan89 avatar Sep 19 '24 21:09 MGaetan89

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 19 '24 21:09 CLAassistant

I see the builds fail on my PR. Is there something I have to fix, or is it the same failures as on master?

MGaetan89 avatar Oct 01 '24 06:10 MGaetan89

Hi @MGaetan89. I have reviewed your PR, and you are right, we don't need multidex anymore, it's a legacy part that remained in our codebase for a long time. Currently we have some issues with the open source builds so they can't run on your PR. I ran our E2E tests for both our apps for the proposed changes on a different branch and they were successful, so I will merge your PR.

Thank you for your contribution.

tamaskozmer avatar Oct 07 '24 12:10 tamaskozmer