pipeline-backend
pipeline-backend copied to clipboard
feat(component,instillmodel): migrate instill model component
Because
- there are breaking change in instill model
This commit
- migrate the instill model component
- migrate the existing pipelines
Note
- QA in the Linear threads
- ✅ QAed Migration
- ✅ QAed Pipeline
- About
Read()&Write(), we will phase them out with Instill Model together, which we will discuss in the future plan.
Hi @jvallesm
Want to clarify if this test code aligns what you think like we discussed before.
Yes! That's the approach, exactly. Kudos, as grpc doesn't contain a standard library test package like httptest (perhaps there's something similar that isn't builtin), so replicating it here wasn't trivial and you got exactly what I meant 👍☹️👍
Perhaps if we have more use cases for this we can build later a wrapper to simplify the process of creating the server and defining its responses. One first step would be adding the mock to the generated code in protogen-go, then perhaps add a test helper package in x
@donch1989 This is what I used now. But, I am not sure if it is same as your imagination.
@donch1989 This is what I used now. But, I am not sure if it is same as your imagination.
Yes, I think we can use that for now and refactor it later.
@donch1989 @jvallesm
Do you have time to review it? Or can we merge it after I rebase it?
And, for the document part, we will need @GeorgeWilliamStrong to review it. Thank you.