console icon indicating copy to clipboard operation
console copied to clipboard

fix: secret deletion glitch

Open thewbuk opened this issue 9 months ago • 8 comments

Because

  • When typing during deleting secret, the modal UI disappears from time to time. - Could not replicate
  • Change "Please type users/user-id/secrets/secret-id" to "Please type secret-id to confirm."

This commit

  • Change "Please type users/user-id/secrets/secret-id" to "Please type secret-id to confirm."

thewbuk avatar May 14 '24 09:05 thewbuk

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 14 '24 09:05 github-actions[bot]

@thewbuk the prettier format is failed, you can run pnpm format in your root folder to fix it. @orangecoloured helped us add this command in the lint-staged in one of his pr. Once we merged it, it will be failed-free. But before that you still need to manually do it

EiffelFly avatar May 14 '24 09:05 EiffelFly

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 14 '24 09:05 github-actions[bot]

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 77.63 KB (1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar May 14 '24 13:05 github-actions[bot]

@thewbuk There is a bug on e2e test caused your PR's e2e test is failed, please help me rebase main and push to remote

EiffelFly avatar May 15 '24 05:05 EiffelFly

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 15 '24 11:05 github-actions[bot]

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 15 '24 12:05 github-actions[bot]