react-native-popup-menu icon indicating copy to clipboard operation
react-native-popup-menu copied to clipboard

[Bug] Cannot read property 'instance' of undefined

Open feidaZhang opened this issue 1 year ago • 2 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

I got the issue from sentry in production. I think it was caused by some render issues. Just add this to avoid the unknown issue. image

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-popup-menu/src/MenuOption.js b/node_modules/react-native-popup-menu/src/MenuOption.js
index bc944ef..fc37090 100644
--- a/node_modules/react-native-popup-menu/src/MenuOption.js
+++ b/node_modules/react-native-popup-menu/src/MenuOption.js
@@ -20,6 +20,9 @@ export class MenuOption extends Component {
 
   _getMenusOnSelect() {
     const menu = this.props.ctx.menuActions._getOpenedMenu();
+    if(!menu) {
+        return () => true
+    }
     return menu.instance.props.onSelect;
   }
 

This issue body was partially generated by patch-package.

feidaZhang avatar Mar 13 '24 08:03 feidaZhang

i meet same error,fix with: ./gradlew clean...rebuild works.

amingsc avatar Apr 05 '24 10:04 amingsc

Screenshot 2024-11-21 at 5 30 51 PM

fernandocortes-sr avatar Nov 21 '24 20:11 fernandocortes-sr