flashbax icon indicating copy to clipboard operation
flashbax copied to clipboard

fix: error when vault's rel_dir is a parent directory

Open callumtilbury opened this issue 1 year ago • 1 comments

Issue raised here, with a very simple fix actually—just normalise the path before processing.

We could look at having an abs_path argument too, but I don't want to change the API or anything right now. This is an easy change, that simply allows the parent directory (..) to be part of the rel_dir.

callumtilbury avatar Jul 22 '24 08:07 callumtilbury

@jcformanek maybe you could take a quick look at this, to approve? Simple test is to have your vault in the parent directory (..)—by using the old flashbax version, an error will be thrown, but this change should fix 💯

callumtilbury avatar Jul 22 '24 08:07 callumtilbury

Why are we type ignoring?

EdanToledo avatar Aug 27 '24 10:08 EdanToledo

@EdanToledo apologies, solved this elsewhere with https://github.com/instadeepai/flashbax/pull/35. Need to update here :)

callumtilbury avatar Aug 29 '24 14:08 callumtilbury

@EdanToledo fixed. Just waiting to confirm that mypy is now happy 🚀

callumtilbury avatar Aug 29 '24 14:08 callumtilbury

@EdanToledo when you're ready: 🤾🏻‍♂️

callumtilbury avatar Aug 29 '24 14:08 callumtilbury