Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[MAINTAIN] Investigate dict.values() and .keys()

Open DriesSmit opened this issue 1 year ago • 0 comments

Please describe what needs to be maintained?

We recently found an error in SMAC where we use dict.values() on a dictionary where the order of the returned values are important. However, dict.values() and dict.keys() might not always be in the order that we added it in. The latest Python version should solve this issue. However, when combining this with jax.jit makes the problem return.

How do we know when maintenance is complete?

Check all dict.keys() and dict.values() and make sure that none of them require a specific ordering to be returned.

DriesSmit avatar Oct 14 '22 08:10 DriesSmit