Mava
Mava copied to clipboard
[BUG] Debug env renders in rgb_array mode
Describe the bug
Even when the mode rgb_array is passed into rendering for the debug env it still displays a window, this can be a nuisance when running locally.
It is possible that we will deprecate this environment in the future so this upgrade should only happen if we decide to keep this environment
To Reproduce
Steps to reproduce the behavior:
- Add the
MonitorExecutorEnvironmentLoop
to your system - Use the Debug Env
- View the windows that pop up
Expected behavior
Rendering should be done in the background and saved to a folder instead of displayed on screen while being saved.
Proposal for a fix
In the render method for debug env handle the rgb_array case by not rendering to the screen. I am not sure how to do this, but I imagine pygame has a way.
Definition of done
When the MonitorExecutorEnvironmentLoop
is added no rendering windows show up during a run.
Mandatory checklist before making a PR
- [ ] The success criteria laid down in āDefinition of doneā are met.
- [ ] Code is documented - docstrings for methods and classes, static types for arguments.
- [ ] Code is tested - unit, integration and/or functional tests are added.
- [ ] Documentation is updated - README, CONTRIBUTING, or other documentation.
- [ ] All functional tests are green.
- [ ] Link experiment/benchmarking after implementation (optional).