Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[BUG] Numpy version

Open mmorris44 opened this issue 2 years ago ā€¢ 0 comments

Describe the bug

Numpy version needs fixing.

To Reproduce

Steps to reproduce the behaviour:

  1. make build version=jax-core
  2. make bash version=jax-core
  3. python examples/jax/debugging/simple_spread/feedforward/decentralised/run_mappo.py
  4. See first error printed: RuntimeError: module compiled against API version 0xf but this version of numpy is 0xe

Expected behavior

Error should ideally not appear.

Context (Environment)

  • On Mac, but in Docker

Proposal for a fix

Seems to arise from conflicting versions of numpy installed during mava build. Need to pin down to one version. Our version does not match with dm-acme's version, but their version has other problems.

Definition of done

Error no longer appearing and example running fine. CI tests passing.

Mandatory checklist before making a PR

  • [ ] The success criteria laid down in ā€œDefinition of doneā€ are met.
  • [ ] Code is documented - docstrings for methods and classes, static types for arguments.
  • [ ] Code is tested - unit, integration and/or functional tests are added.
  • [ ] Documentation is updated - README, CONTRIBUTING, or other documentation.
  • [ ] All functional tests are green.
  • [ ] Link experiment/benchmarking after implementation (optional).

mmorris44 avatar Jun 24 '22 13:06 mmorris44