Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[BUG] RoboCup not working

Open DriesSmit opened this issue 2 years ago • 0 comments

Describe the bug

When running the robocup example using the image mava:robocup-latest I get the following error:

[trainer/0]   File "/home/app/Mava/mava/systems/tf/maddpg/system.py", line 629, in trainer
[trainer/0]     _, networks = self.create_system()
[trainer/0]   File "/home/app/Mava/mava/systems/tf/maddpg/system.py", line 487, in create_system
[trainer/0]     networks = system.create_system()
[trainer/0]   File "/home/app/Mava/mava/components/tf/architectures/decentralised.py", line 343, in create_system
[trainer/0]     critic_networks = self.create_critic_variables()
[trainer/0]   File "/home/app/Mava/mava/components/tf/architectures/decentralised.py", line 386, in create_critic_variables
[trainer/0]     act_spec = act_specs[agent_key]
[trainer/0] KeyError: 'player_0'

To Reproduce

Steps to reproduce the behavior:

  1. make build version=robocup
  2. docker run -it mava:robocup-latest python3 ./examples/tf/robocup/recurrent/state_based/run_mad4pg.py

Expected behaviour

The code should run without crashing.

Context (Environment)

  • Mava (c71349b5)
  • Ubuntu 22.04

Possible Solution

This is probably a small naming issue where player_0 should be some other name like e.g. agent_0.

DriesSmit avatar Jun 20 '22 09:06 DriesSmit