Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[BUG]: Remove Reverb sampler from trainer tf.function.

Open DriesSmit opened this issue 3 years ago • 1 comments

Describe the bug The dataset sampler should still be removed from the MADDPG/MAD4PG tf.function training steps and placed outside. If the sampler is inside tf.function it can possibly sample random noise data, because tf.function messes with its stop calculations.

DriesSmit avatar Jan 22 '22 06:01 DriesSmit

In my experience, having the reverb sample inside tf.function is only a problem when you use a queue. So I expect it to be fine when using a regular replay buffer like in MADQN and MADDPG. Am I wrong? @DriesSmit

jcformanek avatar Feb 11 '22 14:02 jcformanek

Closing all TF issues as we are depreciating our TF systems.

DriesSmit avatar Sep 08 '22 14:09 DriesSmit