truetime-android icon indicating copy to clipboard operation
truetime-android copied to clipboard

_retryCount is never used?

Open scorpiodawg opened this issue 6 years ago • 1 comments

It seems there's a withRetryCount API in the builder but it doesn't seem to be used/supported?

https://github.com/instacart/truetime-android/blob/0630cdf3341b82c2fb16d0ff3e95c32c4ee1a78c/library-extension-rx/src/main/java/com/instacart/library/truetime/TrueTimeRx.java#L31

I was under the impression perhaps that this would provide retry behavior until we reach the max retry count until I looked at the source and realized there are no references to this variable anywhere.

scorpiodawg avatar Oct 02 '18 04:10 scorpiodawg

There is a reference here:

https://github.com/instacart/truetime-android/blob/0630cdf3341b82c2fb16d0ff3e95c32c4ee1a78c/library-extension-rx/src/main/java/com/instacart/library/truetime/TrueTimeRx.java#L225

MarkVillacampa avatar Jan 17 '19 14:01 MarkVillacampa