makara icon indicating copy to clipboard operation
makara copied to clipboard

No CHANGELOG entry for 0.5.1

Open wjessop opened this issue 4 years ago • 5 comments

It looks like this is a relatively small change, but as this gem doesn't explicitly support semantic versioning it's hard to know if there are any breaking changes with the patch release without release notes.

wjessop avatar Jul 30 '21 11:07 wjessop

There are breaking changes.

jeremy avatar Aug 23 '21 23:08 jeremy

Would you be able to expand on what those are? Much appreciated if you are!

wjessop avatar Aug 24 '21 13:08 wjessop

Here's what I've seen:

  • Non-Active Record connection proxies broke: https://github.com/instacart/makara/pull/324
  • Proxying connection methods that are shadowed by private Kernel methods (like… #select) are broken: https://github.com/instacart/makara/issues/326
  • Proxying certain control methods can fail due to funky syntax: https://github.com/basecamp/makara/commit/56e26343116c82cc4253166f6a79236556aa688f

jeremy avatar Aug 25 '21 07:08 jeremy

Apologies, I did not update the Changelog on master since technically this release is on a separate branch, but you can see the changes in the release: https://github.com/instacart/makara/releases/tag/v0.5.1

This contains all the same changes as master except for the deprecations of master and slave, which were reported to have caused issues but we have not had a chance to investigate.

mlarraz avatar Aug 25 '21 12:08 mlarraz

Thanks @jeremy / @mlarraz, that's helpful.

wjessop avatar Aug 26 '21 12:08 wjessop