Snacks icon indicating copy to clipboard operation
Snacks copied to clipboard

Upgrade react + related deps; upgrade react-styleguidist

Open wfro opened this issue 5 years ago • 2 comments

Part 2 of 2 of resolving the CVE here: https://github.com/instacart/snacks/network/alert/yarn.lock/serialize-javascript/open

  • Upgrades react/react-dom from 16.4.2 => 16.12.0
    • Also upgrades any deps that rely on certain versions of react like enzyme/react-test-renderer
  • Upgrades react-styleguidist from 9 => 10. This was the original target package to upgrade since it had the outdated serialize-javascript dependency

wfro avatar Jan 13 '20 18:01 wfro

Codecov Report

Merging #394 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files          62       62           
  Lines        1300     1300           
  Branches      230      230           
=======================================
  Hits         1090     1090           
  Misses        159      159           
  Partials       51       51

codecov[bot] avatar Jan 13 '20 18:01 codecov[bot]

Had to rebase due to lockfile conflicts.

wfro avatar Jan 14 '20 22:01 wfro