Snacks icon indicating copy to clipboard operation
Snacks copied to clipboard
verified publisher icon instacart

Use svgicon for scrolltrack

Open mhui opened this issue 6 years ago • 2 comments

Looks slightly different but close enough. This is so we don't have to import ic-font

Screen Shot 2019-08-12 at 5 50 16 PM Screen Shot 2019-08-12 at 5 50 04 PM

mhui avatar Aug 13 '19 00:08 mhui

Codecov Report

Merging #354 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          59       59           
  Lines        1221     1221           
  Branches      218      218           
=======================================
  Hits         1004     1004           
  Misses        165      165           
  Partials       52       52

codecov[bot] avatar Aug 13 '19 01:08 codecov[bot]

LGTM - more Icon => SVGIcon conversions are always welcome.

Let's test this one using yarn link (I can help with that, I haven't done it in a while myself so I need a refresher anyways) first since it's one of the more used components. I don't think there'll be any issues but can't hurt.

wfro avatar Aug 14 '19 01:08 wfro