Snacks
Snacks copied to clipboard
[WIP] Emotion
Trying out emotion to replace Radium. Making it so the style props are backwards compatible to make potential migration for consumers easier.
This isn't finished, but docs run and all looks great!!
Gonna try it out in its current form on our apps... technically everything should just work.
Still need to:
- [x] pass through
classNameon all components. At least where we currently passstylethrough, to support puttingcss={}on snacks components for overrides (css={}props get turned intoclassNamebeing passed byemotion) - [ ] (??MAYBE??) convert theming system to use
emotiontheming system - [ ] prob some other stuff i can't think of right now
Codecov Report
Merging #331 into master will increase coverage by
0.02%. The diff coverage is100%.
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 82.22% 82.25% +0.02%
==========================================
Files 59 59
Lines 1221 1223 +2
Branches 218 218
==========================================
+ Hits 1004 1006 +2
Misses 165 165
Partials 52 52
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/components/Forms/ValidationError.js | 100% <ø> (ø) |
:arrow_up: |
| src/components/SVGIcon/SVGIcon.js | 100% <ø> (ø) |
:arrow_up: |
| src/base/RadioCheckboxBase.js | 100% <ø> (ø) |
:arrow_up: |
| src/components/Menus/Menu.js | 35.38% <ø> (ø) |
:arrow_up: |
| src/components/Buttons/Switch.js | 100% <ø> (ø) |
:arrow_up: |
| src/components/Tooltip/TooltipPosition.js | 85.71% <ø> (ø) |
:arrow_up: |
| src/components/Forms/MaskedTextField.js | 81.25% <ø> (ø) |
:arrow_up: |
| src/components/Link/Link.js | 100% <ø> (ø) |
:arrow_up: |
| src/components/Forms/TextField.js | 87.5% <ø> (ø) |
:arrow_up: |
| src/components/Tooltip/Tooltip.js | 84% <ø> (ø) |
:arrow_up: |
| ... and 43 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 318fbda...8decc5f. Read the comment docs.