Snacks icon indicating copy to clipboard operation
Snacks copied to clipboard

FormComponent should use defaultProps

Open dcocchia opened this issue 7 years ago • 0 comments

If an id prop is not passed to the FormComponent component, it generates a unique id for labels lower down in the component tree. This is great in some ways, but it has a couple issues:

  • It's not clear in the documentation that this will happen, since it's not using defaultProps
  • This causes issues with snapshot tests for users of the library, since this data is randomized for each test run

Issue 1 has an obvious fix. Issue 2 could just be a requirement for users to supply an id prop during tests.

dcocchia avatar Dec 12 '18 19:12 dcocchia