jsfeat icon indicating copy to clipboard operation
jsfeat copied to clipboard

Not working on chrome after some time

Open praksahsri11 opened this issue 9 years ago • 15 comments

I am checking on chrome latest version. when i run sample orb it is working fine after some time it is creating Aw! Snap error.. When i check on windows task manager it is utilizing the full memory. Can you help me to solve this.

praksahsri11 avatar Dec 18 '15 12:12 praksahsri11

can not reproduce this issue, it seems to be smth related to chrome itself i suppose

inspirit avatar Dec 18 '15 13:12 inspirit

ya. it is problem with the chrome only. older versions and firefox and all working fine. even in chrome when i load the page its working fine, the problem comes only when the image data starts processing it keeps pushing the data in the memory and when gets loaded we get that error. Any work around for this ?

praksahsri11 avatar Dec 18 '15 15:12 praksahsri11

sorry i corrected my answer i can NOT see the issue, it works just fine for me

inspirit avatar Dec 18 '15 15:12 inspirit

can you try in any windows based operating system like windows 7 or 8 only chrome browser. In Linux and MAC OS it is working fine

praksahsri11 avatar Dec 18 '15 16:12 praksahsri11

My Guess

The links on the demo site are relative

<a href="sample_orb.html" target="_blank" role="button" class="btn btn-mini">ORB MATCHING DEMO</a>

If you end up at the demo site without ssl, then navigate to a demo, it will still be http. Since "getUserMedia() no longer works on insecure origins." you will get

screen shot 2016-01-09 at 4 57 16 pm

with the error

screen shot 2016-01-09 at 4 57 34 pm

Navigating to https:

screen shot 2016-01-09 at 4 58 20 pm

This happens for me on both chrome and firefox. Firefox doesn't seem to tell you the appropriate error in the console.

Options?

Make demo site links non relative

<a href="https://inspirit.github.io/jsfeat/sample_orb.html" target="_blank" role="button" class="btn btn-mini">ORB MATCHING DEMO</a>

Mention the https requirement for user media?

PseudoSky avatar Jan 09 '16 22:01 PseudoSky

@PseudoSky i think you are using old version of repo. i've changed everything to https a while ago. the issue reported by @praksahsri11 is smth different

inspirit avatar Jan 10 '16 08:01 inspirit

Oh hmm, I was running them from the demo site

https://inspirit.github.io

http://inspirit.github.io

PseudoSky avatar Jan 10 '16 18:01 PseudoSky

@inspirit Could you update the links on http://inspirit.github.io/jsfeat to use https? I doubt most people would realize the problem was that it isn't https. I almost didn't think to switch. I know the readme links to the https version of the documentation, but people coming from NPM or other sites will find the examples broken.

Nateowami avatar Aug 27 '16 12:08 Nateowami

I don't have access to NPM repo, it was created by someone else. here on github i've changed all the links to be https.

inspirit avatar Aug 27 '16 13:08 inspirit

Yeah, I know you don't have access to the NPM package, but the links on http://inspirit.github.io/jsfeat are not https. They're protocol-dependent. Anyone who reaches the page on http will find the demos broken, with a "WebRTC not available" error message.

Nateowami avatar Aug 27 '16 14:08 Nateowami

well rather than changing all links to absolute (which is not right) I would ask the NPM author to change only one link to make it work actually. i understand that it makes it look like it is broken but this kind of change doesn't feel right to me.

inspirit avatar Aug 27 '16 14:08 inspirit

@inspirit If you go to https://github.com/inspirit/jsfeat/settings and check "Enforce HTTPS" it will redirect HTTP requests to HTTPS.

Nateowami avatar Aug 27 '16 14:08 Nateowami

@Nateowami cool! that was really helpful, thank you! i've changed the setting.

inspirit avatar Aug 27 '16 14:08 inspirit

@inspirit I didn't even know it was possible until right now. They announced it in June: https://github.com/blog/2186-https-for-github-pages

Nateowami avatar Aug 27 '16 14:08 Nateowami

Sadly, that didn't solve the problem, and none of the demos run when viewing the GitHub pages, at least from Chrome on Windows. There are two other tickets commenting on this (#85 and #84).

leegee avatar May 07 '19 11:05 leegee