inspircd icon indicating copy to clipboard operation
inspircd copied to clipboard

m_chanhistory: Use message tags

Open docwhat opened this issue 9 years ago • 7 comments

In order to allow scripts, clients, etc. to handle history replay's correctly, the m_chanhistory module should use message tags to properly identify the replayed history.

To see an example of how it can impact client developers, see cinch issue 193.

It would also be nice if server time was implemented as well.

Note: I'm not super familiar with the IRC protocol and am relaying a feature request described by @dominikh. He may be able to provide more information if technical details are needed.

docwhat avatar Apr 06 '15 21:04 docwhat

~~I don't think this will be possible for 2.2 as we need to rework all of our internal message handling stuff for message tags. Maybe 2.3.~~

SadieCat avatar Apr 07 '15 05:04 SadieCat

Sounds great!

docwhat avatar Apr 07 '15 06:04 docwhat

This is trivial to implement because of the way how m_chanhistory works, it sends raw messages that we can format differently for server-time capable clients.

attilamolnar avatar Apr 07 '15 06:04 attilamolnar

:+1:

Heufneutje avatar Apr 07 '15 07:04 Heufneutje

Based on the initial comment on this issue, I interpret it to mean he wants both server-time tag and another tag to describe that it's specifically history.

Other than server-time, what kind of tag are you thinking of?

kaniini avatar Apr 14 '15 16:04 kaniini

@kaniini Presumably the tag/commands from batch-3.2.

SadieCat avatar Apr 14 '15 16:04 SadieCat

Oh, he didn't mention BATCH. Okay, that makes sense.

kaniini avatar Apr 14 '15 16:04 kaniini

This was resolved in v3 but I missed the issue, oops!

SadieCat avatar Jun 17 '24 16:06 SadieCat