inspectit-ocelot
inspectit-ocelot copied to clipboard
Closes #1300: Use gRPC for agent commands
Codecov Report
Merging #1359 (ddbf7a0) into master (16aef58) will increase coverage by
0.40%
. The diff coverage is73.25%
.
:exclamation: Current head ddbf7a0 differs from pull request most recent head 8d36296. Consider uploading reports for the commit 8d36296 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #1359 +/- ##
============================================
+ Coverage 78.41% 78.81% +0.40%
+ Complexity 2424 2419 -5
============================================
Files 251 248 -3
Lines 7930 7932 +2
Branches 939 939
============================================
+ Hits 6218 6251 +33
+ Misses 1299 1269 -30
+ Partials 413 412 -1
Impacted Files | Coverage Δ | |
---|---|---|
...nspectit/ocelot/core/command/CommandDelegator.java | 16.67% <ø> (ø) |
|
...mmand/handler/impl/ListClassesCommandExecutor.java | 27.42% <52.94%> (ø) |
|
...pectit/ocelot/core/command/AgentCommandClient.java | 62.90% <62.90%> (ø) |
|
...ectit/ocelot/core/command/AgentCommandService.java | 77.97% <77.08%> (+7.23%) |
:arrow_up: |
...mmand/handler/impl/EnvironmentCommandExecutor.java | 100.00% <100.00%> (ø) |
|
...core/command/handler/impl/LogsCommandExecutor.java | 87.50% <100.00%> (+2.50%) |
:arrow_up: |
...core/command/handler/impl/PingCommandExecutor.java | 66.67% <100.00%> (+16.67%) |
:arrow_up: |
Before mergin this PR, we have to make sure that newly added agent commands (e.g., SupportArchive
#1333) are also upgraded to protobuf gRPC
This PR is ready but needs to wait for #1554 to be merged. NOTE: Don't forget to rebase/merge the main branch to this one and test out if everything still works.