inspectit-ocelot icon indicating copy to clipboard operation
inspectit-ocelot copied to clipboard

inspect-IT EUM SRV / Attribute client.ip is set allways to zero

Open SaschaBrechmannVHV opened this issue 3 years ago • 1 comments

The boomerang-ot-plugin will allways set the attribute "client.ip" to zero (0.0.0.0 / 0:0:0:0:0:0:0:0). The JS Agent do not know the IP of the browser, as this is a browser-limitation. The EUM SRV should set this value, from the receiving beacon (http header). It should also respect the "X-forward-for" header and if exists use the most left value.

The HTTP Server Semantic Conventions describe http.client_ip as containing:

The IP address of the original client behind all proxies, if known (e.g. from X-Forwarded-For).

That sounds singular to me, as does the linked MDN document:

X-Forwarded-For: <client>, <proxy1>, <proxy2>

Strikes me we SHOULD take the left-most address only. What do you reckon?

SaschaBrechmannVHV avatar Feb 17 '22 08:02 SaschaBrechmannVHV

Hi @heiko-holz , there is a Cliend-IP Field at the Beacon-Exporter. Will/Could this Function be used to update the Field at the trace-Exporter? Regards, Sascha

mc-chaos avatar Nov 16 '22 09:11 mc-chaos