is-core-module icon indicating copy to clipboard operation
is-core-module copied to clipboard

fix: add `core.json` to `package.json` `exports`

Open SimenB opened this issue 2 years ago • 2 comments

Allows https://github.com/browserify/resolve/commit/122bb64be2f4fcf927fd264d4b2c9ea622611c58 to be just require('is-core-module/core.json')

SimenB avatar Jul 24 '23 22:07 SimenB

Codecov Report

Patch and project coverage have no change.

Comparison is base (77d33fb) 90.47% compared to head (83cb795) 90.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files           1        1           
  Lines          42       42           
  Branches       17       17           
=======================================
  Hits           38       38           
  Misses          4        4           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 24 '23 22:07 codecov[bot]

While this is certainly a technically viable resolution for resolve, I am very very very loath to add to the exposed API of is-core-module.

ljharb avatar Jul 24 '23 22:07 ljharb