dhcp icon indicating copy to clipboard operation
dhcp copied to clipboard

Add option IPv6OnlyPreferred (RFC 8925)

Open candlerb opened this issue 1 year ago • 2 comments

This DHCP option is needed to support https://github.com/coredhcp/coredhcp/pull/170

candlerb avatar Feb 25 '24 15:02 candlerb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.21%. Comparing base (ca2dc33) to head (fb14ecd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   73.07%   73.21%   +0.13%     
==========================================
  Files          80       80              
  Lines        5059     5073      +14     
==========================================
+ Hits         3697     3714      +17     
+ Misses       1219     1216       -3     
  Partials      143      143              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 25 '24 18:02 codecov[bot]

Don't you want to add parsing for this option as well to avoid having to deal with OptGeneric in the coredhcp code?

pmazzini avatar Feb 25 '24 18:02 pmazzini

Good point. Helpers added, and tested with a corresponding patched coredhcp.

candlerb avatar Feb 26 '24 04:02 candlerb

I think this is in shape for a recheck now, thanks.

candlerb avatar Feb 26 '24 05:02 candlerb

Many thanks. I'm good for you to merge this, and #525.

candlerb avatar Feb 27 '24 00:02 candlerb

Thank you!

candlerb avatar Feb 27 '24 16:02 candlerb