dhcp icon indicating copy to clipboard operation
dhcp copied to clipboard

can you release a version?

Open AllenX2018 opened this issue 3 years ago • 5 comments

Hello ~ community maintainer: the community has not released a version for a long time, can you release a version?

AllenX2018 avatar Dec 30 '20 08:12 AllenX2018

CC @pmazzini @hugelgupf @Natolumin . Anything missing before we cut a release? Even better if 1.x ?

insomniacslk avatar Mar 17 '21 20:03 insomniacslk

Chris wanted to remove the async client before the 1.x release: https://github.com/insomniacslk/dhcp/pull/400#issue-487817803

His pinterest/bender PR was never merged though: https://github.com/pinterest/bender/pull/39

I am ok with cutting a release. If we can remove the async client even better.

pmazzini avatar Mar 17 '21 22:03 pmazzini

There isn't anything specifically missing for v1 that I can think of, but anyway if it's just adding missing things we can do it within a minor release

Releasing a v1 means we have to actually be careful about breaking api changes from now on (which I'm definitely happy about), so maybe we want to make a pass at unexporting things we don't want to guarantee stability on, or that aren't directly useful to clients ? There are a couple APIs that have shown to cause issues (most notably ToBytes not being able to error out, but I'm sure there are others I forgot about); on that point I'd say releasing a v1 would be a positive so we can knowingly select things to break with an eventual v2 as well

Natolumin avatar Mar 17 '21 22:03 Natolumin

Let's get it out the door and remove / change things in v2... only have so much time rn

hugelgupf avatar Mar 18 '21 01:03 hugelgupf

Release never happened, maybe a 0.x release at least?

s3rj1k avatar Jul 30 '23 18:07 s3rj1k