dhcp icon indicating copy to clipboard operation
dhcp copied to clipboard

Use github.com/cenkalti/backoff for retries

Open rjoleary opened this issue 5 years ago • 7 comments

Use github.com/cenkalti/backoff to replace the backoff algorithm in https://github.com/insomniacslk/dhcp/pull/296.

The backoff package is well tested and gives the user more control over which backoff method and parameters to use.

rjoleary avatar Jul 29 '19 23:07 rjoleary

I can work on this.

rjoleary avatar Jul 29 '19 23:07 rjoleary

Thanks for working on this! On a phone now and can't remember what was wrong with the current retry system, are you addressing a particular problem that hit you?

insomniacslk avatar Jul 31 '19 09:07 insomniacslk

There'd be two main benefits for using this library. First, it would give more control/options over how the backoff is performed (especially with the BackOff interface). Secondly, this backoff library is well tested.

rjoleary avatar Oct 07 '19 18:10 rjoleary

It doesn't look like this repository has a vendor directory. How would you want to make the dependency on github.com/cenkalti/backoff ?

rjoleary avatar Oct 07 '19 18:10 rjoleary

I'd just make it without managing it, same as with u-root so far.

When u-root is ready we should go to modules?

hugelgupf avatar Oct 07 '19 21:10 hugelgupf

I can work on this.

@rjoleary Are you looking at this?

pmazzini avatar Apr 25 '21 15:04 pmazzini

I'll take over this.

heinz-boehmer avatar Aug 11 '21 22:08 heinz-boehmer