dhcp icon indicating copy to clipboard operation
dhcp copied to clipboard

Added osx to continuous integration

Open insomniacslk opened this issue 6 years ago • 6 comments

As discussed in https://github.com/insomniacslk/dhcp/issues/229 we need to test on all the OSes we support

insomniacslk avatar Jan 17 '19 09:01 insomniacslk

I will also commit the fix for FreeBSD and OSX in this PR so I won't merge until then

insomniacslk avatar Jan 17 '19 13:01 insomniacslk

Seems okay, still need those *BSD fixes though :)

get9 avatar Feb 11 '19 16:02 get9

Seems okay, still need those *BSD fixes though :)

yeah, we didn't have time to work on it yet :( this PR won't be merged until the darwin build is fixed

insomniacslk avatar Feb 12 '19 09:02 insomniacslk

Codecov Report

Merging #230 into master will increase coverage by 1.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   73.25%   74.39%   +1.13%     
==========================================
  Files          75       69       -6     
  Lines        3717     3116     -601     
==========================================
- Hits         2723     2318     -405     
+ Misses        862      703     -159     
+ Partials      132       95      -37
Impacted Files Coverage Δ
netboot/netconf.go 55.35% <0%> (-12.42%) :arrow_down:
dhcpv6/modifiers.go 62.29% <0%> (-8.72%) :arrow_down:
dhcpv6/dhcpv6message.go 51.94% <0%> (-6.02%) :arrow_down:
dhcpv4/dhcpv4.go 79.66% <0%> (-0.66%) :arrow_down:
dhcpv4/modifiers.go 88.23% <0%> (-0.34%) :arrow_down:
dhcpv4/option_ip_address_lease_time.go 100% <0%> (ø) :arrow_up:
dhcpv4/ztpv4/parse_circuitid.go 87.87% <0%> (ø) :arrow_up:
netboot/netboot.go 0% <0%> (ø) :arrow_up:
dhcpv4/nclient4/client.go
dhcpv4/nclient4/conn_linux.go
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc1a534...dc25849. Read the comment docs.

codecov[bot] avatar Apr 04 '19 13:04 codecov[bot]

rebased

insomniacslk avatar Jul 15 '19 21:07 insomniacslk

I think BSD was fixed but now we switched to Github CI. Do you want to update this PR?

pmazzini avatar Oct 25 '21 22:10 pmazzini