DHCPv6: Other ALL_CAPS constants to CamelCase

[get9]

This changes all other ALL_CAPS constants in various other files in dhcpv6 to CamelCase. These are a bit more controversial changes and IMO don't enhance readability (in some cases, it makes it worse)... Feel free to comment whether you agree or disagree with these changes.

[codecov[bot]]

Codecov Report

Merging #107 into master will not change coverage. The diff coverage is 64.28%.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files          66       66           
  Lines        3006     3006           
=======================================
  Hits         1843     1843           
  Misses       1058     1058           
  Partials      105      105

Impacted Files	Coverage Δ
dhcpv6/option_archtype.go	76.19% <ø> (ø)	:arrow_up:
dhcpv6/option_nii.go	0% <ø> (ø)	:arrow_up:
dhcpv6/dhcpv6message.go	48.27% <0%> (ø)	:arrow_up:
dhcpv6/utils.go	89.28% <100%> (ø)	:arrow_up:
dhcpv6/duid.go	67.94% <66.66%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23c03c8...3693c7d. Read the comment docs.

[insomniacslk]

I agree with you that this may not improve readability, rather just make the go linter happier. In cases like DUID_LLT -> DuidLLT, it should probably be DUIDLLT because it's all acronyms, but it would be worse than the other two options. I wouldn't like DuidLlt either. However I don't have a strong opinion on this. @pmazzini what's your thought?

[pmazzini]

I don't have a strong opinion about it either.

[get9]

So what should we do here?

[insomniacslk]

hey @get9 , sorry for making you wait. Given that this would be a breaking change (and in https://github.com/insomniacslk/dhcp/issues/123 I committed to doing no breaking changes before versioning - or, I'd add now, unless really necessary), and that there is no strong reasoning in either direction, I'd rather not do this change and delay it until later