react-heatpack icon indicating copy to clipboard operation
react-heatpack copied to clipboard

Less

Open pwmckenna opened this issue 9 years ago • 3 comments

builds off of the incomplete babel6 pr.

@insin this is a question as much as a PR. the css loading is specified in a way I've never seen. why the combine loaders, then the + '!'. I couldn't seem to get less loading to work in the same way. Also, are the require.resolve statements necessary?

pwmckenna avatar Dec 10 '15 23:12 pwmckenna

Everything which is configured with require.resolve is to save us having to worry about which working directory heatpack is running in, as the config points at absolute paths to heatpack's own dependencies.

The manual tagging on of the ! for autoprefixer is because autoprefixer can't deal with an empty query object - see https://github.com/jsdf/webpack-combine-loaders/pull/1. I ended up rolling my own version of this for nwb, where it's done this way to allow the user to tweak the configuration of every loader, so that might have been some cross-pollination :)

insin avatar Dec 11 '15 00:12 insin

@insin this should be ready now...any idea how many types of files you'd like to support?

pwmckenna avatar Dec 28 '15 20:12 pwmckenna

@pwmckenna It'd also be nice to include sass/scss support, since those are fairly commonly used too. I don't mind making another PR based on this one, but it seems like @insin might've forgotten about this?

sohkai avatar Feb 10 '16 15:02 sohkai