control-panel-for-twitter icon indicating copy to clipboard operation
control-panel-for-twitter copied to clipboard

Wrong word "ツイートする" used as heading of Tweet view in Japanese

Open kawapure opened this issue 1 month ago • 4 comments

It should just say "ツイート", which is the noun "Tweet". "ツイートする" is a verb phrase exclusively meaning to make a tweet. It is appropriate for the Tweet button, which officially said it when the Twitter branding was still used, but the Tweet header just said "ツイート". I am using version 4.14.1 on Firefox 128 on Windows 10.

Example:

Image

What it should say:

Image

kawapure avatar Nov 13 '25 23:11 kawapure

I believe I have found the relevant code, but I am not sure how to work a fix into the current localisation system.

https://github.com/insin/control-panel-for-twitter/blob/6c04e87725231fff604ea8a37afcfa516fdb8c01/script.js#L6577-L6579

kawapure avatar Nov 13 '25 23:11 kawapure

Japanese translations are here:

https://github.com/insin/control-panel-for-twitter/blob/master/_locales/ja/messages.json https://github.com/insin/control-panel-for-twitter/blob/master/scripts/locales/base-locales.json#L559

insin avatar Nov 14 '25 00:11 insin

There is a standalone string for "ツイート" in base-locales.json already (the plural TWEETS), but it doesn't appear to be used for this heading. If I understand it correctly, it shares the text with the buttons to make Tweets, which use TWEET. Therefore I don't think this is something which can be trivially fixed by changing existing messages (other than doing away with the する on the buttons, which isn't strictly wrong, but inaccurate to older versions of RWeb).

The best way to fix this is probably by adding an additional string in the locales for this heading, but I am afraid this would have to be needlessly duplicated across other languages where such a distinction does not exist, which, albeit clean, could be a bit much to facilitate a simple change. Japanese is the only language I know of with a contextual distinction here, so maybe a language-specific hack could be added, but that's not clean, so I don't know if it would be desirable.

kawapure avatar Nov 14 '25 00:11 kawapure

We can add a noun variant and update getString to take multiple codes to try, e.g. getString('TWEET_NOUN', 'TWEET'), then only languages for which the noun/verb distinction is relevant need to provide that string.

I'll have a look in Twitter's own locale files later to look at how they resolve this for Japanese.

insin avatar Nov 14 '25 11:11 insin