Jonny Buchanan

Results 130 comments of Jonny Buchanan

I think that's an nwb problem - do you have an example I could play with?

Not currently, but we could add a prop which takes a `test` function which would receive the current filter and the item being tested: The current implementation is effectively this:...

It's even worse when user voting changes the comment order. This is currently a really dumb implementation which just renders exactly what the Firebase API spits out rather than attempting...

Assuming this was related to HackerNews/API#6, but will need to improve the error message handling, which was based on any errors I've happened to see and been able to get...

Thanks for the PR, I like having a single dark mode toggle in place - removes the temptation I was feeling to go all YAGNI while adding a single new...

This is because there's no `babel` dependency in `package.json` - there should be and it should match the version nwb is using to avoid duplicating it. This works by coincidence...

Yes, `babel-register` is a separate package in Babel 6, so it'll need to be Babel 5 for now.

Something Monokai-ey? ![firefox_2016-06-30_04-27-43](https://cloud.githubusercontent.com/assets/226692/16463866/14010210-3e7b-11e6-9dd6-b562bec17057.png)

Does this count? https://medium.com/@jbscript/lazy-live-data-with-react-79ed1cb1f4d6

Assuming you have eslint, eslint-loader and whatever plugins you need installed, plus an `.eslintrc`, it should be something like this: ```js var extraWebpackConfig = { module: { rules: [ {...