teal icon indicating copy to clipboard operation
teal copied to clipboard

[Bug]: Error/warning message when data is not sufficient and no teal transform modules

Open gogonzo opened this issue 1 year ago • 2 comments

What happened?

When data provided to the teal::init has insufficient datasets and none of the modules have teal_transform_module specified it clearly means that some modules are missing some datasets.

What we need is to make an assert/warning in teal::init to throw message when:

  • datasets available in data argument don't cover all possible modules$datanames
  • None of the modules have transforms specified (means that list of datasets won't be extended by teal_transform_module)

When we address https://github.com/insightsengineering/teal/issues/1298 it will be possible to determine all possible datanames including those created in teal_transform_module so the message will be thrown when:

  • datasets available in data argument don't cover all possible modules$datanames and teal_transform_module$datanames

gogonzo avatar Aug 08 '24 08:08 gogonzo

Proposition for an improvement in here https://github.com/insightsengineering/teal/pull/1309, but blocked by https://github.com/insightsengineering/teal/issues/1298

m7pr avatar Aug 12 '24 12:08 m7pr

Hey, I provided

  • a PR for the top part of the issue https://github.com/insightsengineering/teal/pull/1319
  • a DRAFT for the second part of the issue https://github.com/insightsengineering/teal/pull/1320 (but this is blocked by https://github.com/insightsengineering/teal/issues/1298)

m7pr avatar Aug 14 '24 09:08 m7pr

Closed with https://github.com/insightsengineering/teal/pull/1319

m7pr avatar Aug 28 '24 07:08 m7pr