teal.modules.clinical icon indicating copy to clipboard operation
teal.modules.clinical copied to clipboard

default arguments crash app (`tm_g_pp_vitals`)

Open chlebowa opened this issue 2 years ago • 5 comments

What happened?

Example app in tm_g_pp_vitals crashes when some arguments are set to NULL even though those arguments default to NULL.

With paramcd = NULL: image

With xaxis = NULL: image

With aval = NULL: image

Possibly the case in other modules as well.

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • [X] I agree to follow this project's Contribution Guidelines.

Security Policy

  • [X] I agree to follow this project's Security Policy.

chlebowa avatar Dec 19 '22 10:12 chlebowa

I think it's hard to set default values for these parameters so maybe NULL was selected. @shajoezhu thoughts?

Looks like we have a good error catch with paramcd but not the others.

donyunardi avatar Jun 26 '24 16:06 donyunardi

this is a bit odd. though, i feel there is some data issue in this too. Hi @chlebowa , any chance you can share the data with me?

shajoezhu avatar Jun 26 '24 22:06 shajoezhu

I believe @chlebowa was just using the example code in the function's roxygen doc. You can try that code and set xaxis or aval to NULL.

donyunardi avatar Jun 27 '24 03:06 donyunardi

cool! Thanks a lot Dony!, Let me try that!

shajoezhu avatar Jun 27 '24 03:06 shajoezhu

I believe @chlebowa was just using the example code in the function's roxygen doc.

Correct.

chlebowa avatar Jun 27 '24 07:06 chlebowa