tm_a_mmrm validation remarks

[cicdguy]

• [ ] no asserts in the template functions
• [ ] if you fail to fit the model (say by using the filter panel to filter on AGE) and then change inputs (i.e. remove the filtering) then although the main error message is removed - the one on the optimizer isn't:

<REDACTED>user/2703/files/ba6bba00-3575-11eb-9e13-e02492ba5238)

I would add a req() statement to remove the error message from the encoding panel entirely

• [ ] Would be great if when the model is successfully fit, the model panel is automatically closed - @SUNDRELV is this easy to do?

• [ ] Validation on inputs to module e.g. paramcd, arm_var

• [ ] Typo "generatd" in code comments

Provenance:

Creator: nikolas-burkoff

[cicdguy]

• [ ] Would be great if when the model is successfully fit, the model panel is automatically closed - @SUNDRELV is this easy to do?

Wow, good idea. However even with the panel_group enhancements this is not yet possible. The reason is because we have to send information from the server to the UI (something like a updatePanelGroupInput) instead of the other way around.

It can be done but I think it falls under a new feature request.

Provenance:

Creator: SUNDRELV

[cicdguy]

thx @nikolas-burkoff - so seems like it works well in general. given time constraints these are more polishing things. so moving to backlog.

Provenance:

Creator: danielinteractive

[danielinteractive]

There might be a few good dev ops improvements in here. So would be good as a filler some time.