Savant icon indicating copy to clipboard operation
Savant copied to clipboard

%source_id and %src_filename are not respected in image_file sink adapter

Open heyryanw opened this issue 1 year ago • 1 comments

Running on 0.2.10, the two params are not respected when used in the DIR_LOCATION environment variable. It instead will output to a path like: /some/path/%source_id-%src_filename

heyryanw avatar Jun 06 '24 13:06 heyryanw

To fix in:

  • 0.2.x
  • 0.3.x
  • develop

bwsw avatar Jun 10 '24 13:06 bwsw

  1. images and meta are written to different directories.
  2. substitutions do not work well.
  3. add %chunk_idx to documentation.
  4. ensure that when %src_filename is missing, it works properly.

To backport to 0.4 and release 0.4.6

  sink:
    image: ghcr.io/insight-platform/savant-adapters-py:latest
    restart: unless-stopped
    volumes:
      - zmq_sockets:/tmp/zmq-sockets
      - ../../out:/out
    environment:
      - ZMQ_ENDPOINT=sub+connect:ipc:///tmp/zmq-sockets/output-video.ipc
      - CHUNK_SIZE=100
      - DIR_LOCATION=/out/%source_id/%chunk_idx
      - DEV_MODE=True
    entrypoint: /opt/savant/adapters/python/sinks/image_files.py

image

bwsw avatar Sep 24 '24 09:09 bwsw