Savant icon indicating copy to clipboard operation
Savant copied to clipboard

Substitution parameter not supported in Image File Sink and Video File Sink

Open Y-T-G opened this issue 1 year ago • 1 comments

The documentation for Image File Sink and Video File Sink says:

DIR_LOCATION: a location to write files to; can be a regular path or a path template; supported substitution parameters are %source_id and %src_filename;

But only JSON Metadata Sink supports this. In the code, I don't see any pattern replacement being done for Image File Sink and Video File Sink.

Y-T-G avatar Jan 11 '24 09:01 Y-T-G

@Y-T-G Note that the first frame of a video file sould be a keyframe. That mean that video files sink should start a new chunk only on a keyframe.

E.g.: A source adapter sent two files (1.mp4, 2.mp4) to the module. The module encoded 5 first frames from 2.mp4 as non-keyframes; a frame #6 is a keyframe. In that case the video files sink adapter should write those 5 frames to the last chunk for 1.mp4. Then the adapter should create a chunk for 2.mp4 and write frame #6 (keyframe) and the following frames to this chunk.

tomskikh avatar Jan 15 '24 07:01 tomskikh

Related to #772

bwsw avatar Sep 24 '24 09:09 bwsw