angular-promise-extras icon indicating copy to clipboard operation
angular-promise-extras copied to clipboard

Field 'state' is wrongly named

Open wiedehoeft opened this issue 2 years ago • 4 comments

Hi, I wanted to make a PR, but have no access rights. In my opinion the field 'state' must be renamed to 'status', as you can see in MDN documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled

The TS typings are correct which currently enforces casting of results.

wiedehoeft avatar Aug 25 '21 13:08 wiedehoeft

open a PR, I'll merge it.

insidewhy avatar Aug 25 '21 15:08 insidewhy

I am unable to create a branch

git push --set-upstream origin fixStateName
ERROR: Permission to insidewhy/angular-promise-extras.git denied to wiedehoeft.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

wiedehoeft avatar Aug 25 '21 17:08 wiedehoeft

I wanted to make a PR, but have no access rights.

You never need access rights to create a PR, see:

https://guides.github.com/activities/forking/

insidewhy avatar Aug 25 '21 17:08 insidewhy

Opened PR :)

wiedehoeft avatar Aug 25 '21 18:08 wiedehoeft