angular-promise-extras
angular-promise-extras copied to clipboard
Field 'state' is wrongly named
Hi, I wanted to make a PR, but have no access rights. In my opinion the field 'state' must be renamed to 'status', as you can see in MDN documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled
The TS typings are correct which currently enforces casting of results.
open a PR, I'll merge it.
I am unable to create a branch
git push --set-upstream origin fixStateName
ERROR: Permission to insidewhy/angular-promise-extras.git denied to wiedehoeft.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
I wanted to make a PR, but have no access rights.
You never need access rights to create a PR, see:
https://guides.github.com/activities/forking/
Opened PR :)