vim-search-pulse icon indicating copy to clipboard operation
vim-search-pulse copied to clipboard

Explicitly enable pulse-on-same-line

Open thirtythreeforty opened this issue 10 years ago • 3 comments

Hello! This is a very cool plugin; I like it a lot!

Reading through the code, I see you explicitly don't pulse when the next match is on the same line as the last match. I would prefer that the cursorline pulse regardless of where the next match is. Could you provide an option to do that? Or, would you be open to a pull request that implements it?

Also, there is a slight glitch with the current behavior. Currently, if I press /foo<cr> to start a search, then <C-F>n to scroll up a page and jump to the next "foo", then the found foo (the one I jumped away from) is not highlighted, because it's the same line as the previous pulse. More generally, I think that moving away from a match's line, then returning to it, should pulse the cursorline.

thirtythreeforty avatar Oct 26 '15 21:10 thirtythreeforty

Hello George!

A pull request that implements this option would be much appreciated :-) And if you are willing to fix the slight glitch it would be awesome.

Keep on enjoying this plugin,

Best

On Mon, Oct 26, 2015 at 10:22 PM, George Hilliard [email protected] wrote:

Hello! This is a very cool plugin; I like it a lot!

Reading through the code, I see you explicitly don't pulse when the next match is on the same line as the last match. I would prefer that the cursorline pulse regardless of where the next match is. Could you provide an option to do that? Or, would you be open to a pull request that implements it?

Also, there is a slight glitch with the current behavior. Currently, if I press /foo to start a search, then <C-F>n to scroll up a page and jump to the next "foo", then the found foo (the one I jumped away from) is not highlighted, because it's the same line as the old one. More generally, moving away from a match's then returning to it should also pulse.

— Reply to this email directly or view it on GitHub https://github.com/inside/vim-search-pulse/issues/8.

Yann / Front developer @ Dailymotion

inside avatar Oct 28 '15 09:10 inside

FYI, I'm working on a PR for this

jebaum avatar Feb 23 '16 08:02 jebaum

Awesome, thanks!!

inside avatar Feb 23 '16 08:02 inside