Include attachments in TSV and JSON formatted output
Hello. This is a patch for https://github.com/insanum/gcalcli/issues/827. Following your lead in https://github.com/insanum/gcalcli/issues/829. Happy to continue iterating on this if you have any feedback. Thank you.
The Attachments.patch method has been updated to refine its read-only behavior. Previously, any attempt to patch the attachments field would unconditionally raise a ReadonlyCheckError.
With this change, the method now first compares the provided value with the event's current_value for attachments. A ReadonlyCheckError is only raised if an actual modification is attempted (i.e., current_value != value). This allows for "patching" the attachments field with its existing value without triggering an error, while still preventing any actual changes to a different value.
New tests have been added to confirm this behavior, ensuring that patching with an unchanged value succeeds and patching with a different value correctly raises a ReadonlyCheckError.
@kody start-review
Code Review Completed! 🔥
The code review was successfully completed based on your current configurations.
Kody Guide: Usage and Configuration
Interacting with Kody
-
Request a Review: Ask Kody to review your PR manually by adding a comment with the
@kody start-reviewcommand at the root of your PR. -
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.
Current Kody Configuration
@reviewOptions
FYI the check failures are just some unused imports and long lines the linter wants you to fix.
Code Review Completed! 🔥
The code review was successfully completed based on your current configurations.
Kody Guide: Usage and Configuration
Interacting with Kody
-
Request a Review: Ask Kody to review your PR manually by adding a comment with the
@kody start-reviewcommand at the root of your PR. -
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.
Current Kody Configuration
@reviewOptions
Code Review Completed! 🔥
The code review was successfully completed based on your current configurations.
Kody Guide: Usage and Configuration
Interacting with Kody
-
Request a Review: Ask Kody to review your PR manually by adding a comment with the
@kody start-reviewcommand at the root of your PR. -
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.
Current Kody Configuration
@reviewOptions
@dbarnett hi, checking in to see if there's anything else I can do to help get this merged. Thank you.