gcalcli icon indicating copy to clipboard operation
gcalcli copied to clipboard

Include attachments in TSV and JSON formatted output

Open shanemcd opened this issue 2 months ago • 6 comments

Hello. This is a patch for https://github.com/insanum/gcalcli/issues/827. Following your lead in https://github.com/insanum/gcalcli/issues/829. Happy to continue iterating on this if you have any feedback. Thank you.


The Attachments.patch method has been updated to refine its read-only behavior. Previously, any attempt to patch the attachments field would unconditionally raise a ReadonlyCheckError.

With this change, the method now first compares the provided value with the event's current_value for attachments. A ReadonlyCheckError is only raised if an actual modification is attempted (i.e., current_value != value). This allows for "patching" the attachments field with its existing value without triggering an error, while still preventing any actual changes to a different value.

New tests have been added to confirm this behavior, ensuring that patching with an unchanged value succeeds and patching with a different value correctly raises a ReadonlyCheckError.

shanemcd avatar Oct 14 '25 18:10 shanemcd

@kody start-review

dbarnett avatar Oct 24 '25 03:10 dbarnett

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

@reviewOptions

Access your configuration settings here.

kody-ai[bot] avatar Oct 24 '25 03:10 kody-ai[bot]

FYI the check failures are just some unused imports and long lines the linter wants you to fix.

dbarnett avatar Oct 24 '25 03:10 dbarnett

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

@reviewOptions

Access your configuration settings here.

kody-ai[bot] avatar Oct 28 '25 18:10 kody-ai[bot]

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

@reviewOptions

Access your configuration settings here.

kody-ai[bot] avatar Oct 28 '25 18:10 kody-ai[bot]

@dbarnett hi, checking in to see if there's anything else I can do to help get this merged. Thank you.

shanemcd avatar Dec 03 '25 19:12 shanemcd